Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken URLs #6617

Merged
merged 2 commits into from
Sep 24, 2022
Merged

Fixed broken URLs #6617

merged 2 commits into from
Sep 24, 2022

Conversation

radarhere
Copy link
Member

https://github.com/python-pillow/Pillow/actions/runs/3113355066/jobs/5047881943#step:11:560

(releasenotes/5.2.0: line 108) broken https://pillow.readthedocs.io/en/5.1.x/about.html#why-a-fork - 404 Client Error: Not Found for url: https://pillow.readthedocs.io/en/5.1.x/about.html

The link is shown at https://pillow.readthedocs.io/en/stable/releasenotes/5.2.0.html#resolve-confusion-getting-pil-pillow-version-string. It is a deliberate example of a broken URL, so I've reworded the sentence to avoid referring to it

https://github.com/python-pillow/Pillow/actions/runs/3113355066/jobs/5047881943#step:11:515

(releasenotes/versioning: line 24) broken https://github.com/python-pillow/Pillow/blob/main/RELEASING.md#point-release - Anchor 'point-release' not found
(releasenotes/versioning: line 24) broken https://github.com/python-pillow/Pillow/blob/main/RELEASING.md#embargoed-release - Anchor 'embargoed-release' not found

https://github.com/python-pillow/Pillow/actions/runs/3113355066/jobs/5047881943#step:11:518

(releasenotes/versioning: line 14) broken https://github.com/python-pillow/Pillow/blob/main/RELEASING.md#main-release - Anchor 'main-release' not found

Inspecting the headings at https://github.com/python-pillow/Pillow/blob/main/RELEASING.md, I found that the anchors actually have a prefix of 'user-content-'.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, the original link works when I click it and they also link to those with href="#main-release", but the anchor ID does have the prefix, id="user-content-main-release":

image

@hugovk hugovk added the automerge Automatically merge PRs that are ready label Sep 24, 2022
@radarhere radarhere merged commit e8fdab3 into python-pillow:main Sep 24, 2022
@radarhere radarhere deleted the url branch September 25, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PRs that are ready Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants